Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove datasets with inconsistent levels #21

Closed
wants to merge 1 commit into from
Closed

Remove datasets with inconsistent levels #21

wants to merge 1 commit into from

Conversation

stefsmeets
Copy link
Contributor

Remove datasets with deviating levels.

Fixes #19

@stefsmeets stefsmeets mentioned this pull request Jan 28, 2021
Open
Peter9192
Peter9192 approved these changes Jan 29, 2021
View reviewed changes
Copy link

@Peter9192 Peter9192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me. Good idea to keep them under 'ignored', so we can always get them back if we want to add new tests for code that should address this.

@stefsmeets stefsmeets closed this Jun 29, 2021
@bouweandela
Copy link
Member

Thanks @stefsmeets! Following discussion in ESMValGroup/ESMValCore#956 and with the new feature proposed in ESMValGroup/ESMValCore#1177 this will probably not be needed anymore.

@bouweandela bouweandela deleted the ignore_data_deviating_plevs branch July 9, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Peter9192 Peter9192 Peter9192 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some datasets have deviating plev coordinates
3 participants
@stefsmeets @bouweandela @Peter9192