Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Snapshots Should Return Valid OSCAL Content #77

Closed
Tracked by #82
brian-comply0 opened this issue Jan 26, 2024 · 4 comments
Closed
Tracked by #82

Get Snapshots Should Return Valid OSCAL Content #77

brian-comply0 opened this issue Jan 26, 2024 · 4 comments
Assignees

Comments

@brian-comply0
Copy link
Contributor

brian-comply0 commented Jan 26, 2024

For the following GET endpoints, the return content incorrectly adds -snapshot to the root element for all three return formats (XML, JSON, and YAML):

  • GET /{model-name}/{identifier}
  • GET /{model-name}/{identifier}/snapshot/{identifier}
  • GET /profile/{identifier}/resolved-snapshot/{identifier}

These endpoints should always return a valid OSCAL file. Adding -snapshot to the root element invalidates the OSCAL content by creating root elements not recognized by OSCAL content validation capabilities.

@brian-comply0
Copy link
Contributor Author

2024-02-07 deferring until controls internal MVP is achieved. Moving to next sprint just to track.

@brian-comply0
Copy link
Contributor Author

Made good progress on the collection of issues. This one will be addressed in sprint 68.

@pjavan
Copy link

pjavan commented May 21, 2024

@mpemy and @brian-comply0 what do we need to do to get this finished?

@brian-comply0
Copy link
Contributor Author

With the exception of the XML problem noted in issue #78, this is satisfied. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants