Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate external toolchains better #296

Closed
5 tasks
carstene1ns opened this issue Jul 7, 2014 · 6 comments
Closed
5 tasks

Integrate external toolchains better #296

carstene1ns opened this issue Jul 7, 2014 · 6 comments

Comments

@carstene1ns
Copy link
Member

  • Add command line options to configure to compile for wii, gcw0, etc. or use CMake Toolchain files
  • Set default flags, defines and variables, but allow user overriding
  • Use macros to conditionally compile sources
  • Clean up builds folder, remove Makefiles

more to come

@carstene1ns carstene1ns changed the title Automake: integrate external toolchains Autotools: integrate external toolchains Jul 7, 2014
@carstene1ns carstene1ns changed the title Autotools: integrate external toolchains Integrate external toolchains better Jul 17, 2014
@carstene1ns
Copy link
Member Author

After #1365, this should now be done with CMake. 👍
(Wow, has been 4 years already)

@fmatthew5876
Copy link
Contributor

How about this one @carstene1ns ?

Are any of these still relevant after all the build system changes we've had recently?

@Ghabry
Copy link
Member

Ghabry commented Dec 18, 2018

Not really, we still use the same, old Makefiles we always used (look in the builds folder) for anything that is not Windows, Linux, emscripten (Web) or OSX.

The only progress we ever had here is that Windows is now buildable via CMake.

The next one will be libretro via CMake and these changes are a good base for further work (because they make the CMakeLists more generic).

@Ghabry
Copy link
Member

Ghabry commented Feb 14, 2019

No idea if this is relevant for us. Solution for one 3DS-CMake problem: devkitPro/pacman-packages#41

I noticed that all the undefined references came from 3dsx_crt0.s and that they were defined in libctru.

Adding -L/opt/devkitpro/libctru/lib -lctru to the CMAKE_EXE_LINKER_FLAGS fixed the issue for me.
(> I'm saying this because the issue came back when you re-added set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -specs=3dsx.specs") and I finally figured out what was causing it.)

@Ghabry
Copy link
Member

Ghabry commented Apr 28, 2021

With CMake 3.20 a new cli option "presets" was added.

This allows reading presets from a json file (https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html).

Could be useful to make the CMake invocation less verbose and reduce redundancy in jenkins when we use specific ci-presets.

@carstene1ns
Copy link
Member Author

I consider this one fixed with #2627.

@carstene1ns carstene1ns added this to the 0.7.1 milestone Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants