Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to process unexpected CM_SLAC_PARM message #16

Open
tropxy opened this issue Apr 12, 2022 · 0 comments
Open

Unable to process unexpected CM_SLAC_PARM message #16

tropxy opened this issue Apr 12, 2022 · 0 comments

Comments

@tropxy
Copy link
Contributor

tropxy commented Apr 12, 2022

According to the spec, at any point in time, if a CM_SLAC_PARM.REQ is received, the application must interpret it as a reset of the Slac process and process the Slac parameter message (this means a reset of the state machine).

The issue is that with the current code, the application is unable to jump to a state where processes the slac parm request and continues with the rest of the flow. This is a design flaw and requires refactoring.

A state design pattern may be the best fit for the job:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant