Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix value for ATTEN_RESULTS_TIMEOUT #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OrangeTux
Copy link

@OrangeTux OrangeTux commented Sep 6, 2023

The maximum value for ATTEN_RESULTS_TIMEOUT is 1050. Trying a higher number cause an error:

pyslac-slac-1  | DEBUG:asyncio:Using selector: EpollSelector
pyslac-slac-1  | Traceback (most recent call last):
pyslac-slac-1  |   File "/venv/lib/python3.10/site-packages/pyslac/examples/single_slac_session.py", line 93, in <module>
pyslac-slac-1  |     run()
pyslac-slac-1  |   File "/venv/lib/python3.10/site-packages/pyslac/examples/single_slac_session.py", line 89, in run
pyslac-slac-1  |     asyncio.run(main())
pyslac-slac-1  |   File "/usr/local/lib/python3.10/asyncio/runners.py", line 44, in run
pyslac-slac-1  |     return loop.run_until_complete(main)
pyslac-slac-1  |   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 641, in run_until_complete
pyslac-slac-1  |     return future.result()
pyslac-slac-1  |   File "/venv/lib/python3.10/site-packages/pyslac/examples/single_slac_session.py", line 77, in main
pyslac-slac-1  |     slac_config.load_envs(env_path)
pyslac-slac-1  |   File "/venv/lib/python3.10/site-packages/pyslac/environment.py", line 47, in load_envs
pyslac-slac-1  |     env.seal()  # raise all errors at once, if any
pyslac-slac-1  |   File "/venv/lib/python3.10/site-packages/environs/__init__.py", line 447, in seal
pyslac-slac-1  |     raise EnvValidationError(f"Environment variables invalid: {error_messages}", error_messages)
pyslac-slac-1  | environs.EnvValidationError: Environment variables invalid: {'ATTEN_RESULTS_TIMEOUT': ['Must be less than or equal to 1050.']}

Fixes #48

The maximum value for `ATTEN_RESULTS_TIMEOUT` is 1050. Trying a higher
number cause an error:

```
pyslac-slac-1  | DEBUG:asyncio:Using selector: EpollSelector
pyslac-slac-1  | Traceback (most recent call last):
pyslac-slac-1  |   File "/venv/lib/python3.10/site-packages/pyslac/examples/single_slac_session.py", line 93, in <module>
pyslac-slac-1  |     run()
pyslac-slac-1  |   File "/venv/lib/python3.10/site-packages/pyslac/examples/single_slac_session.py", line 89, in run
pyslac-slac-1  |     asyncio.run(main())
pyslac-slac-1  |   File "/usr/local/lib/python3.10/asyncio/runners.py", line 44, in run
pyslac-slac-1  |     return loop.run_until_complete(main)
pyslac-slac-1  |   File "/usr/local/lib/python3.10/asyncio/base_events.py", line 641, in run_until_complete
pyslac-slac-1  |     return future.result()
pyslac-slac-1  |   File "/venv/lib/python3.10/site-packages/pyslac/examples/single_slac_session.py", line 77, in main
pyslac-slac-1  |     slac_config.load_envs(env_path)
pyslac-slac-1  |   File "/venv/lib/python3.10/site-packages/pyslac/environment.py", line 47, in load_envs
pyslac-slac-1  |     env.seal()  # raise all errors at once, if any
pyslac-slac-1  |   File "/venv/lib/python3.10/site-packages/environs/__init__.py", line 447, in seal
pyslac-slac-1  |     raise EnvValidationError(f"Environment variables invalid: {error_messages}", error_messages)
pyslac-slac-1  | environs.EnvValidationError: Environment variables invalid: {'ATTEN_RESULTS_TIMEOUT': ['Must be less than or equal to 1050.']}
```g
@OrangeTux OrangeTux marked this pull request as ready for review September 6, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make dev fails EnvValidationError
2 participants