Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Take update_batch_size into consideration when dividing total_num_envs and buffer sizes etc #66

Closed
3 tasks done
EdanToledo opened this issue Apr 25, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@EdanToledo
Copy link
Owner

EdanToledo commented Apr 25, 2024

Describe the bug

Currently, we take into account the number of devices when setting the total number of envs and/or buffer size, batch size but we dont take into account the update_batch_size variable. Generally, this is a non-issue since the default is 1 however this is important to keep in my mind.

Fix for :

  • Num envs
  • Buffer size
  • Batch Size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant