getLinkTarget.xql fails if window title not found for mei:work

[bwbohl]

Edirom-Online/add/data/xql/getLinkTarget.xql

Line 170 in 914ccfd

declare function local:getWindowTitle($doc as node()+, $type as xs:string) as xs:string {

e.g. in MEI 4.0.1 work does no longer contain titleStmt

[bwbohl]

Edirom-Online/add/data/xql/getLinkTarget.xql

Line 172 in 914ccfd

if (exists($doc//mei:mei) and exists($doc//mei:workDesc/mei:work) and not(exists($doc//mei:perfMedium)))

fails for MEI 4 upward because mei:workDesc was replaced with mei:workList

[peterstadler]

Is the function failing by throwing an error or is it returning "unknown" where you would expect some title text?

[riedde]

I have tested this with an MEI 5 file. I hade to delete a lot of titles before nothing was returned, but I was not able to force a fail. At the end an emptry string was retuned.

Since @bwbohl mentioned #118 here: Special characters and hard linebreaks have been a problem since I can remember. The linebreak issue was simply fixed by normalizing the space.
But also with a title containing the apostrophe I am not able to reproduce this case. @bwbohl Could you provide me a title-Container that I can copy&paste into my test set?

[bwbohl]

The current implelemtation

Edirom-Online/add/data/xql/getLinkTarget.xql

Lines 150 to 189 in d3f4ce4

	(:~
	: Returns the window title for an edirom-object
	:)
	declare function local:getWindowTitle($doc as node()+, $type as xs:string) as xs:string {
	(: Work :)
	if (exists($doc//mei:mei) and exists($doc//mei:workDesc/mei:work) and not(exists($doc//mei:perfMedium))) then
	(eutil:getLocalizedTitle(($doc//mei:work)[1]/mei:titleStmt[1], $lang))
	else if (exists($doc/root()/mei:work)) then
	(eutil:getLocalizedTitle($doc/root()/mei:work, $lang))
	(: Recording :)
	else if (exists($doc//mei:mei) and exists($doc//mei:recording)) then
	(eutil:getLocalizedTitle($doc//mei:fileDesc/mei:titleStmt[1], $lang))
	(: Source / Score :)
	else if ($type = 'source' and exists($doc//mei:manifestation/mei:titleStmt)) then
	(string-join((eutil:getLocalizedTitle(($doc//mei:manifestation)[1]/mei:titleStmt[1], $lang),
	($doc//mei:manifestation)[1]//mei:identifier[lower-case(@type) = 'shelfmark'][1]), ' | ')
	=> normalize-space())
	else if ($type = 'source' and exists($doc//mei:source/mei:titleStmt)) then
	(string-join((eutil:getLocalizedTitle(($doc//mei:source)[1]/mei:titleStmt[1], $lang),
	($doc//mei:source)[1]//mei:identifier[lower-case(@type) = 'shelfmark'][1]), ' | ')
	=> normalize-space())
	(: MEI fallback if no title is found :)
	else if (exists($doc//mei:mei) and exists(($doc//mei:titleStmt)[1])) then
	(eutil:getLocalizedTitle(($doc//mei:titleStmt)[1], $lang))
	(: Text :)
	else if (exists($doc/tei:TEI)) then
	(eutil:getLocalizedTitle($doc//tei:fileDesc/tei:titleStmt[1], $lang))
	(: HTML :)
	else if ($type = 'html') then
	($doc//head/data(title))
	else
	(string('unknown'))
	};

As we can see from the above, normalize-space() is only called for source objects
We should apply it to all object types

[riedde]

The normalisation already happens in eutil:getLocalizedTitle()

[bwbohl]

hmm… please test #103 it fails in my local instance