[BUG] Edirom fails when no edition lang is defined

[riedde]

Describe the problem
When no default lang is defined in the data the edirom fails. I think the problem occurs here

Edirom-Online/add/data/xqm/edition.xqm

Line 76 in 8742faa

declare function edition:getLanguageFileURI($uri as xs:string, $lang as xs:string) as xs:string {

To Reproduce
Delete the language from the preferences and/or the edirom-edition-file.

Expected behavior
If no lang is defined the edirom should use the default lang of the software (

Edirom-Online/add/data/prefs/edirom-prefs.xml

Line 25 in 8742faa

<entry key="application_language" value="de"/>

). I remember, that we already fixed this but maybe not for this case.

Data
Use any data and play with the lang definition.

Edirom information

• Version on develop (2024-10-11)

Environment information

• Standard

[peterstadler]

I think it's rather this function that should be fixed:

Edirom-Online/add/data/xqm/util.xqm

Lines 305 to 316 in 8742faa

	declare function eutil:getLanguage($edition as xs:string?) as xs:string {
	if (request:get-parameter("lang", "") != "") then
	request:get-parameter("lang", "")
	else if(request:get-cookie-names() = 'edirom-language') then
	request:get-cookie-value('edirom-language')
	else
	eutil:getPreference('application_language', edition:findEdition($edition))
	};

… since eutil:getLanguage#1 might return an empty string.

My suggestion would be to hard code a default value as the last else case to make sure to always return something sensible.

When at it, I think we should modify this function to not only get but also set the language. Currently, this is only done at index.xql at

Edirom-Online/add/controller.xql

Line 38 in c96595d

<set-header name="Set-Cookie" value="edirom-language={$langVal}" />

but I think we should be able to set the language more dynamically (without reloading the page).

[riedde]

Setting a language would be good. I wanted to fix the other function because there also isn‘t a default. If the preferences return a default the function you mentioned should never return empty(). But we can implement a default for both.