Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No API/function retrieve a existing notification_key #2

Open
bhullar89 opened this issue Oct 12, 2018 · 3 comments
Open

No API/function retrieve a existing notification_key #2

bhullar89 opened this issue Oct 12, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@bhullar89
Copy link

bhullar89 commented Oct 12, 2018

I accidentally missed to store the notification_key after creating a device group.
But when try to create same group with same device , i get below error

{
    "error": {
        "code": 400,
        "message": "Client error: `POST https://android.googleapis.com/gcm/notification` resulted in a `400 Bad Request` response:\n{\"error\":\"notification_key already exists\"}\n"
    }
}

Please support for getting existing notification key by passing group name
https://android.googleapis.com/gcm/notification?notification_key_name=the_name

I dont want to stop using library due to this one func,all my implementation is already done :(

@EdwinHoksberg EdwinHoksberg added the enhancement New feature or request label Oct 14, 2018
@bhullar89
Copy link
Author

@EdwinHoksberg
any plans for this enhancement ??
Also if we can handle if there is no device in group , the notification key gets deleted.

@EdwinHoksberg
Copy link
Owner

Hi, I was kinda busy with different things, sorry for the late reply! I want to implement this soon so it should be ready in a few days, but I would also accept PR's for this 😉

@rolinger
Copy link
Collaborator

@bhullar89 - we have some new developers on the project now. We will see about adding your request to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants