Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vite-plugin-ruby 5.1.0 is not compatible with the latest version of vite_ruby 3.8.1 #493

Closed
1 of 2 tasks
robbevp opened this issue Sep 5, 2024 · 0 comments
Closed
1 of 2 tasks
Labels
bug: pending triage Something doesn't seem to be working, but hasn't been verified

Comments

@robbevp
Copy link

robbevp commented Sep 5, 2024

  • I have tried upgrading by running bundle update vite_ruby.
  • I have read the troubleshooting section before opening an issue.

Description 📖

I use dependabot for my upgrades, and got PRs for both vite_ruby 3.8.1 and vite-plugin-ruby 5.1.0

The upgrade of vite-plugin-ruby from 5.0.0 to 5.1.0 fails because, it is not compatible with `vite_ruby 3.8.1

Looking at https://github.com/ElMassimo/vite_ruby/blob/main/vite_ruby/lib/vite_ruby/version.rb#L8 I would expect 5.1.0 to satisfy the requirement.

Reproduction 🐞

Failing PR from dependabot: robbevp/feed-reader#446

Running bin/rake vite:info fails because of the compatibility check, see log below

Logs 📜

If not providing a reproduction:

Output ``` > DEBUG=vite-plugin-ruby:* bin/vite build /nix/store/f1dy1swvhipwjkvia93g8m096q3mnk5w-ruby3.3-vite_ruby-3.8.1/lib/ruby/gems/3.3.0/gems/vite_ruby-3.8.1/lib/vite_ruby/compatibility_check.rb:24:in `raise_unless_satisfied': vite-plugin-ruby@^5.1.0 might not be compatible with vite_ruby-3.8.1 (ArgumentError) ```
@robbevp robbevp added the bug: pending triage Something doesn't seem to be working, but hasn't been verified label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: pending triage Something doesn't seem to be working, but hasn't been verified
Projects
None yet
Development

No branches or pull requests

1 participant