Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton Plugin #232

Open
dmlayton opened this issue Jan 10, 2022 · 0 comments
Open

Skeleton Plugin #232

dmlayton opened this issue Jan 10, 2022 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@dmlayton
Copy link

This is probably best as a plugin rather than a feature request, but I think Elder's architecture lends itself to something I have yet to see automatic, perfectly sized skeletons.

What I notice in my own process is that I put dummy data in while styling dynamic components, then I wire up the dynamic portion. Invariably I discover a few places wherein a store or reactive element fails during the static build and some workaround is needed. Then the rendered page has some empty bits that are never seen when live but are visible when javascript is disabled.

There are many solutions to this, but I think we could turn it into a big positive by adding a hook that replaces dummy elements with skeleton replacements. This could be done in a way that doesn't add any additional overhead -- usually, this requires one to specify the rendered size (which is hard to get right).

Any thoughts?

@eight04 eight04 added the help wanted Extra attention is needed label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants