From 4dd6d7be30f1a029fcdb3d895558f3536370ebbc Mon Sep 17 00:00:00 2001 From: Matthew Treinish Date: Wed, 19 Jul 2023 12:38:14 -0400 Subject: [PATCH] Remove list argument broadcasting and simplify transpile() (Qiskit/qiskit#10291) * Remove list argument broadcasting and simplify transpile() This commit updates the transpile() function to no longer support broadcast of lists of arguments. This functionality was deprecated in the 0.23.0 release. As part of this removal the internals of the transpile() function are simplified so we don't need to handle broadcasting, building preset pass managers, parallel dispatch, etc anymore as this functionality (without broadcasting) already exists through the transpiler API. Besides greatly simplifying the transpile() code and using more aspects of the public APIs that exist in the qiskit.transpiler module, this commit also should fix the overhead we have around parallel execution due to the complexity of supporting broadcasting. This overhead was partially addressed before in Qiskit/qiskit#7789 which leveraged shared memory to minimize the serialization time necessary for IPC but by using `PassManager.run()` internally now all of that overhead is removed as the initial fork will have all the necessary context in each process from the start. Three seemingly unrelated changes made here were necessary to support our current transpile() API without building custom pass manager construction. The first is the handling of layout from intlist. The current Layout class is dependent on a circuit because it maps Qubit objects to a physical qubit index. Ideally the layout structure would just map virtual indices to physical indices (see Qiskit/qiskit#8060 for a similar issue, also it's worth noting this is how the internal NLayout and QPY represent layout), but because of the existing API the construction of a Layout is dependent on a circuit. For the initial_layout argument when running with multiple circuits to avoid the need to broadcasting the layout construction for supported input types that need the circuit to lookup the Qubit objects the SetLayout pass now supports taking in an int list and will construct a Layout object at run time. This effectively defers the Layout object creation for initial_layout to run time so it can be built as a function of the circuit as the API demands. The second is the FakeBackend class used in some tests was constructing invalid backends in some cases. This wasn't caught in the previous structure because the backends were not actually being parsed by transpile() previously which masked this issue. This commit fixes that issue because PassManagerConfig.from_backend() was failing because of the invalid backend construction. The third issue is a new _skip_target private argument to generate_preset_pass_manager() and PassManagerConfig. This was necessary to recreate the behavior of transpile() when a user provides a BackendV2 and either `basis_gates` or `coupling_map` arguments. In general the internals of the transpiler treat a target as higher priority because it has more complete and restrictive constraints than the basis_gates/coupling map objects. However, for transpile() if a backendv2 is passed in for backend paired with coupling_map and/or basis_gates the expected workflow is that the basis_gates and coupling_map arguments take priority and override the equivalent attributes from the backend. To facilitate this we need to block pulling the target from the backend This should only be needed for a short period of time as when Qiskit/qiskit#9256 is implemented we'll just build a single target from the arguments as needed. Fixes Qiskit/qiskit#7741 * Fix _skip_target logic * Fix InstructionScheduleMap handling with backendv2 * Fix test failure caused by exception being raised later * Fix indentation error * Update qiskit/providers/fake_provider/fake_backend.py Co-authored-by: John Lapeyre * Fix standalone dt argument handling * Remove unused code * Fix lint * Remove duplicate import in set_layout.py A duplicate import slipped through in the most recent rebase. This commit fixes that oversight and removes the duplicate. * Update release notes Co-authored-by: Jake Lishman * Adjust logic for _skip_transpile to check if None * Simplify check cmap code * Only check backend if it exists --------- Co-authored-by: John Lapeyre Co-authored-by: Jake Lishman --- qiskit_ibm_provider/fake_provider/fake_1q.py | 8 -------- qiskit_ibm_provider/fake_provider/fake_backend.py | 2 ++ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/qiskit_ibm_provider/fake_provider/fake_1q.py b/qiskit_ibm_provider/fake_provider/fake_1q.py index cf1d7354a..075894761 100644 --- a/qiskit_ibm_provider/fake_provider/fake_1q.py +++ b/qiskit_ibm_provider/fake_provider/fake_1q.py @@ -89,11 +89,3 @@ def __init__(self): general=[], ) super().__init__(configuration) - - def defaults(self): - """defaults == configuration""" - return self._configuration - - def properties(self): - """properties == configuration""" - return self._configuration diff --git a/qiskit_ibm_provider/fake_provider/fake_backend.py b/qiskit_ibm_provider/fake_provider/fake_backend.py index 54aa272c8..923196f58 100644 --- a/qiskit_ibm_provider/fake_provider/fake_backend.py +++ b/qiskit_ibm_provider/fake_provider/fake_backend.py @@ -474,6 +474,8 @@ def _setup_sim(self): def properties(self): """Return backend properties""" coupling_map = self.configuration().coupling_map + if coupling_map is None: + return None unique_qubits = list(set().union(*coupling_map)) properties = {