Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Send entire wallet balance" option to the send workflow. #40

Open
nuttycom opened this issue Apr 8, 2024 · 0 comments
Open

Add "Send entire wallet balance" option to the send workflow. #40

nuttycom opened this issue Apr 8, 2024 · 0 comments
Labels
P-medium Medium priority
Milestone

Comments

@nuttycom
Copy link
Contributor

nuttycom commented Apr 8, 2024

Is your feature request related to a problem? Please describe.

In order to move funds between wallets, it's useful to be able to send the full balance out of the wallet to a recipient. Due to the complexities of fee calculation presented by ZIP 317 the user will likely not be able to accurately guess the fee amount required to empty their wallet, so computing this amount should be the responsibility of the wallet.

Describe the solution you'd like

The top-line balance of the wallet should be equal to the total funds that could be received at an Orchard address when emptying the wallet. The send flow UI should include an alternative to the amount field that is something like a "send maximum value" option. When this option is selected, the transaction proposal should transfer the maximum possible value out of the wallet to a recipient address, correctly accounting for ZIP 317 considerations. Remaining dust-valued UTXOs should be ignored.

Alternatives you've considered

The current design of the top-line balance API does not take fees required to spend into consideration.

Additional context

How this issue is resolved is also related to #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-medium Medium priority
Projects
None yet
Development

No branches or pull requests

2 participants