Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOs Actions #4976

Closed
wants to merge 7 commits into from
Closed

Conversation

4ydan
Copy link
Contributor

@4ydan 4ydan commented Jul 3, 2023

#4973

Basics

  • Short descriptions of your changes are in the release notes
    (added as entry in doc/news/_preparation_next_release.md which contains _(my name)_)
    Please always add them to the release notes.
  • Details of what you changed are in commit messages
    (first line should have module: short statement syntax)
  • References to issues, e.g. close #X, are in the commit messages.
  • The buildservers are happy. If not, fix in this order:
    • add a line in doc/news/_preparation_next_release.md
    • reformat the code with scripts/dev/reformat-all
    • make all unit tests pass
    • fix all memleaks
    • fix the CI itself (or rebase if already fixed)
  • The PR is rebased with current master.

Checklist

  • I added unit tests for my code
  • I fully described what my PR does in the documentation
    (not in the PR description)
  • I fixed all affected documentation (see Documentation Guidelines)
  • I fixed all affected decisions (see Decision Process)
  • I added code comments, logging, and assertions as appropriate (see Coding Guidelines)
  • I updated all meta data (e.g. README.md of plugins and METADATA.ini)
  • I mentioned every code not directly written by me in reuse syntax

Review

Labels

  • Add the "work in progress" label if you do not want the PR to be reviewed yet.
  • Add the "ready to merge" label if everything is done and no further pushes are planned by you.

@atmaxinger
Copy link
Contributor

atmaxinger commented Jul 6, 2023

Have you tried brew install [email protected] and brew pin [email protected] ?

@4ydan
Copy link
Contributor Author

4ydan commented Jul 6, 2023

Have you tried brew install [email protected] and brew pin [email protected] ?

Brew install didnt work because a higher version is installed, brew pin I didnt try.

@atmaxinger
Copy link
Contributor

Well, it wouldn't work either way, just tried it. Seems like this solution here is the only way to do it.

Copy link
Contributor

@markus2330 markus2330 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, when it solves the problem, please merge.

@4ydan
Copy link
Contributor Author

4ydan commented Jul 6, 2023

Yea, the best would be probably to port libelektra to 2.5.6 and avoid dark magic in the yml file.

@atmaxinger
Copy link
Contributor

Does libelektra actually directly depend upon libassuan? Or is this a transitive dependency?

@markus2330
Copy link
Contributor

It is only a development dependency, for ASAN builds. I don't think anyone would use it for production builds.

@4ydan
Copy link
Contributor Author

4ydan commented Jul 8, 2023

Will try some stuff on the macos github actions on my fork, will close this to not start the other pipelines.

@4ydan 4ydan closed this Jul 8, 2023
@4ydan 4ydan changed the title Attempt fixing cirrus build all Fix macOs Actions by downgrading gpgme to 1.19.0 Jul 8, 2023
@4ydan 4ydan reopened this Jul 8, 2023
@4ydan
Copy link
Contributor Author

4ydan commented Jul 9, 2023

These tests behave very weird, I removed all my changes, and the macos/cirrus tests pass now.
I doubt that its just because of macos12 or brew cleanup. Also the jenkins pipeline fails randomly for no reason :s

@4ydan 4ydan changed the title Fix macOs Actions by downgrading gpgme to 1.19.0 Fix macOs Actions Jul 9, 2023
@atmaxinger
Copy link
Contributor

jenkins build libelektra please

@atmaxinger
Copy link
Contributor

It seems like time itself fixed this issue. So there's probably been a package update in homebrew, this PR is no longer needed. Thanks for working on it anyways!

@4ydan
Copy link
Contributor Author

4ydan commented Jul 11, 2023

Nice!

@4ydan 4ydan closed this Jul 11, 2023
@4ydan 4ydan deleted the 4973-fix-build branch July 11, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants