Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: Use typesafe_cb in plugin_timer #3504

Closed
cdecker opened this issue Feb 11, 2020 · 1 comment · Fixed by #3527
Closed

cleanup: Use typesafe_cb in plugin_timer #3504

cdecker opened this issue Feb 11, 2020 · 1 comment · Fixed by #3527
Labels
cleanup

Comments

@cdecker
Copy link
Member

cdecker commented Feb 11, 2020

As part of #3488 the plugin_timer gained a new cb_arg that must match the type of the last argument in the cb function. typesafe_cb can be used to get compiler errors and avoid having to cast to a specific type in cb.
@cdecker cdecker mentioned this issue Feb 11, 2020
Merged
1 task
@darosior
Copy link
Collaborator

Self-assignement ;)

@darosior darosior mentioned this issue Feb 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libplugin: use a typesafe_cb for plugin_timer darosior/lightning
2 participants
@cdecker @darosior