From 14337119f07fa492d847bd0bc285d5b9cf112add Mon Sep 17 00:00:00 2001 From: Saibato Date: Fri, 8 Nov 2019 22:03:25 +0100 Subject: [PATCH] We state not to do 'any local DNS' if --always-use-proxy flag is set, so we should this Even if it is on startup only once ... Like @bitcoin-software indicated the expected UX should be in line with what a user expects the software will do so we should not dns if we say so with a flag that suggest that. Changelog-Fixed: We disable all dns even on startup the scan for bogus dns servers, if --always-use-proxy is set true Signed-off-by: Saibato --- connectd/connectd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/connectd/connectd.c b/connectd/connectd.c index 4e44c49ac83e..fcc619112256 100644 --- a/connectd/connectd.c +++ b/connectd/connectd.c @@ -200,8 +200,8 @@ static bool broken_resolver(struct daemon *daemon) const char *hostname = "nxdomain-test.doesntexist"; int err; - /* If they told us to never do DNS queries, don't even do this one */ - if (!daemon->use_dns) { + /* If they told us to never do DNS queries, don't even do this one and also not if we just say that we don't */ + if (!daemon->use_dns || daemon->use_proxy_always) { daemon->broken_resolver_response = NULL; return false; }