Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: msatoshi in sendpay route got deprecated #92

Closed
nepet opened this issue Jul 7, 2022 · 2 comments
Closed

CLN: msatoshi in sendpay route got deprecated #92

nepet opened this issue Jul 7, 2022 · 2 comments

Comments

@nepet
Copy link
Contributor

nepet commented Jul 7, 2022 •
edited
Loading

ElementsProject/lightning@08d5776 deprecates the msatoshi field which currently leads to jsonrpc errors.

We have to remove the duplicate field in the route hints. One have to check on backwards compatibility as one of the fields was optional before.
@nepet
Copy link
Contributor Author

nepet commented Jul 8, 2022

ElementsProject/lightning#5306 seems to lack backwards compatibility and is discussed in ElementsProject/lightning#5386.

@wtogami
Copy link
Contributor

wtogami commented Jul 13, 2022

This was fixed recently in CLN master branch.

@wtogami wtogami closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wtogami @nepet