Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change bundle tool to Rollup and gen the esm #57

Closed
wants to merge 3 commits into from
Closed

Change bundle tool to Rollup and gen the esm #57

wants to merge 3 commits into from

Conversation

Aloento
Copy link

@Aloento Aloento commented May 9, 2022

I haven't read your entire project, so you may need to make some changes to fit your reality.

@elringus
Copy link
Owner

elringus commented May 9, 2022

Hi, Thanks for the PR, but I'm not comfortable with rollup and would prefer using webpack for the time being.

@Aloento
Copy link
Author

Aloento commented May 9, 2022

in fact, it's esbuild.
https://github.com/Elringus/DotNetJS/blob/847b913bee7cceb2b7b7544bd80b9eedb06615c3/JavaScript/dotnet-runtime/rollup.config.js#L5
and the product doesn't have anything like this:
image
so you are be able to make change.
and I fixed the "this / self / globalThis" issue.

@elringus
Copy link
Owner

elringus commented May 10, 2022

Thank you, this will be helpful in case we'll decide to switch to rollup (which looks like the current standard for ES module building). I'd like to first wait for .NET 7 release (which promises some modularization feats) and see if we can drop the custom branch. After that I'll look into migrating the library to ES.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants