Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add second option for adding OpNames to whole module #736

Closed
khyperia opened this issue Aug 26, 2021 · 0 comments · Fixed by #742
Closed

Add second option for adding OpNames to whole module #736

khyperia opened this issue Aug 26, 2021 · 0 comments · Fixed by #742
Assignees
Labels
t: enhancement A new feature or improvement to an existing one.

Comments

@khyperia
Copy link
Contributor

Right now, OpNames for the whole module is enabled by setting debuginfo to be enabled in cargo (passed on to rustc). This isn't very discoverable, and while docs should definitely be improved to make it be more discoverable, it'd be nice to add another option to enable OpNames for the whole module in spirv-builder - similar to how name_variables exists today. (both the spirv-builder and cargo config option would do the same thing)

(maybe change name_variables into a more generic sounding option, and turn it into an enum {None, Variables, Everything} or something, idk)

@khyperia khyperia added the t: enhancement A new feature or improvement to an existing one. label Aug 26, 2021
@khyperia khyperia self-assigned this Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t: enhancement A new feature or improvement to an existing one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant