Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize path: Allow default repo, default branch #14

Open
Erudition opened this issue Mar 24, 2023 · 1 comment
Open

Customize path: Allow default repo, default branch #14

Erudition opened this issue Mar 24, 2023 · 1 comment
Labels
status: pinned Should not be labeled as stale type: feature New feature or feature request

Comments

@Erudition
Copy link

It would be nice if instead of this:

https://username.github.io/preview-repo/username/preview-repo/branch/master/

I could have this:

https://username.github.io/preview-repo/

which is much more reasonable for a base URL for a webapp.

  • the default branch can be selected, e.g. master/main/latest/release or whatever, that bypasses the `/branch/master/ extensions
  • in the case of single repo usage, or with a default repo selected, the redundant /username/preview-repo can be dropped too.
  • some might also use it for multiple repos, but they're all authored by themselves, so might as well drop the repo author bit in that case.

In all other cases, the full path works fine.

It would also be nice to be able to customize e.g. /pr/number/ to /with-pr/number or even just /number, and the same for branches.

Thanks for this super useful project!

@EndBug
Copy link
Owner

EndBug commented Mar 24, 2023

That's a great idea!
We could add a preview_relative_path input so that users can override the default path: this way we don't risk introducing any breaking changes, we don't have to deal with all the possible scenarios, and we're sure that it's 100% customizable ✅

@EndBug EndBug added type: feature New feature or feature request status: pinned Should not be labeled as stale labels Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: pinned Should not be labeled as stale type: feature New feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants