Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An bug in EntityTarget which may cause to leak of memory #513

Open
MrMks opened this issue Apr 26, 2021 · 1 comment
Open

An bug in EntityTarget which may cause to leak of memory #513

MrMks opened this issue Apr 26, 2021 · 1 comment

Comments

@MrMks
Copy link

MrMks commented Apr 26, 2021

In my test, two instance of EntityTarget of the same player will have different hashcode and the two instance do not be equal, mainly because of the implement of the equal() method of Location.

By removing the check about loc in method hashcode() & equal(Object), the mechanic looks running correctly.

Sorry for my bad english, since it is not my mother language.
@goflishMC
Copy link

Can you join our discord and report this issue? I am continuing development of skillapi updated to latest mc 1.16 https://discord.gg/RhTyRReKyP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@goflishMC @MrMks