Make action work on all OS #19

joshrlesch · 2020-09-16T20:48:53Z

This action is only supported on Linux since its container based. Is it possible to support multiple OS for use with self-hosted runners like internal Macs.

The text was updated successfully, but these errors were encountered:

EnricoMi · 2020-09-17T06:30:14Z

That is a good question. So I think the only alternative to a container action would be the Composite run steps. That should work on Linux, MacOS, Windows. Do you agree?

I presume you can mix operating systems and self-hosted with GitHub-hosted jobs in the same workflow. For the time being, you could then run your tests on your self-hosted MacOS runners and upload the test result files as artifacts. In a separate job in the same workflow you can then publish the unit test results using a GitHub-hosted Linux based job:

jobs:
  test:
    runs-on: [self-hosted, macOs]
  ...
    - name: Upload Unit Test Results
      if: always()
      uses: actions/upload-artifact@v2
      with:
        name: Unit Test Results
        path: **/*.xml

  publish-test-results:
    name: "Publish Unit Tests Results"
    needs: test
    runs-on: ubuntu-latest
    if: always()

    steps:
      - name: Download Artifacts
        uses: actions/download-artifact@v2
        with:
          path: artifacts

      - name: Publish Unit Test Results
        uses: EnricoMi/publish-unit-test-result-action@master
        with:
          check_name: Unit Test Results
          github_token: ${{ secrets.GITHUB_TOKEN }}
          files: "artifacts/**/*.xml"

Is that an option for you?

joshrlesch · 2020-09-17T14:05:23Z

Thanks for the reply! I think that is a decent alternative for the time being. Since you marked this with a enhancement label, do you think it's possible to add support for multi OS's? I know there is a limitation by GH for this to work out of the box, but if there is a change that would be great!

EnricoMi · 2020-09-17T17:04:15Z

I'll try the 'composite run steps' action. I don't see why this shouldn't work. And you are right, having this run on multiple OS would be great.

EnricoMi · 2020-09-25T09:52:54Z

Hi,

I have turned this action into a "composite run steps action".

Please give it a try:

uses: EnricoMi/publish-unit-test-result-action@branch-composite-action

You need to add a python step before this action:

- name: Setup Python
  uses: actions/setup-python@v2
  with:
    python-version: 3

EnricoMi · 2020-10-10T12:28:36Z

@joshrlesch have you had a chance to try the "composite run steps action" on MacOS?

joshrlesch · 2020-10-12T13:20:23Z

@joshrlesch have you had a chance to try the "composite run steps action" on MacOS?

I kinda have. I tried it quick, but ran into python environment errors on our Macs. I wasn't able to look into it much further, but still plan on getting to this sometime.

EnricoMi · 2020-10-12T14:42:26Z

Do you run this on a public github? Then I could look into the action's output.

joshrlesch · 2020-10-12T15:00:09Z

Do you run this on a public github? Then I could look into the action's output.

Nope, this is a private company repo. Hopefully I can get to this later this week.

EnricoMi · 2020-10-12T17:20:16Z

Alright. Did you see that you need to add a Python step before this action now? See https://github.com/EnricoMi/publish-unit-test-result-action/tree/branch-composite-action#using-this-action.

jonathanmedd · 2021-02-09T18:01:14Z

I'd be interested in running this on windows-latest. I tried the above with:

- name: Setup Python
  uses: actions/setup-python@v2
  with:
    python-version: 3

- name: Publish Unit Test Results
  uses: EnricoMi/publish-unit-test-result-action@branch-composite-action
  if: always()
  with:
    github_token: ${{ secrets.GITHUB_TOKEN }}
    files: tools\testResults.xml

but got the following error:

Install Python dependencies
  Collecting pip
    Downloading pip-21.0.1-py3-none-any.whl (1.5 MB)
  Installing collected packages: pip
    Attempting uninstall: pip
      Found existing installation: pip 21.0.1
      Uninstalling pip-21.0.1:
        Successfully uninstalled pip-21.0.1
  Successfully installed pip-21.0.1
  Collecting virtualenv
    Downloading virtualenv-20.4.2-py2.py3-none-any.whl (7.2 MB)
  Collecting distlib<1,>=0.3.1
    Downloading distlib-0.3.1-py2.py3-none-any.whl (335 kB)
  Collecting filelock<4,>=3.0.0
    Downloading filelock-3.0.12-py3-none-any.whl (7.6 kB)
  Collecting appdirs<2,>=1.4.3
    Downloading appdirs-1.4.4-py2.py3-none-any.whl (9.6 kB)
  Collecting six<2,>=1.9.0
    Downloading six-1.15.0-py2.py3-none-any.whl (10 kB)
  Installing collected packages: six, filelock, distlib, appdirs, virtualenv
  Successfully installed appdirs-1.4.4 distlib-0.3.1 filelock-3.0.12 six-1.15.0 virtualenv-20.4.2
  created virtual environment CPython3.9.1.final.0-64 in 3255ms
    creator CPython3Windows(dest=D:\a\BricksetModule\BricksetModule\venv, clear=False, no_vcs_ignore=False, global=False)
    seeder FromAppData(download=False, pip=bundle, setuptools=bundle, wheel=bundle, via=copy, app_data_dir=C:\Users\runneradmin\AppData\Local\pypa\virtualenv)
      added seed packages: pip==21.0.1, setuptools==52.0.0, wheel==0.36.2
    activators BashActivator,BatchActivator,FishActivator,PowerShellActivator,PythonActivator,XonshActivator
  D:\a\_temp\9385afb1-1783-4090-9189-59028d9e99d9.sh: line 5: venv/bin/activate: No such file or directory
  Error: Process completed with exit code 1.

Were you expecting it to work on windows-latest yet?

EnricoMi · 2021-02-16T08:52:22Z

You can test the action from this branch:

uses: EnricoMi/publish-unit-test-result-action@branch-composite-action-win

Be reminded this is just a development branch.

EnricoMi · 2021-02-16T09:30:40Z

@joshrlesch I have tested the composite action on Mac OS X (10.15.7) and it works.

jonathanmedd · 2021-02-16T11:40:32Z

@EnricoMi Tested fine for me on windows-latest

wildmichael · 2021-04-09T07:53:23Z

@EnricoMi The composite-action-win branch works fine on windows-latest, but currently fails on ubuntu-latest. The branch composite-action shows the exact opposite behavior. Any chance of getting both to work?

EnricoMi · 2021-04-11T11:44:22Z

@joshrlesch @jonathanmedd @wildmichael This action is not available as a composite action from master branch. Please give it a try:

- name: Publish Unit Test Results
  uses: EnricoMi/publish-unit-test-result-action/composite@master
  if: always()
  with:
    files: test-results/**/*.xml

Note that master is a development branch and may break any time, so do not use in production.

This will be released soon and will be available via @v1 then.

jonathanmedd · 2021-04-12T11:13:04Z

@EnricoMi Tried it on windows-latest, get this issue:

Publish Unit Test Results
  Traceback (most recent call last):
    File "D:\a\_actions\EnricoMi\publish-unit-test-result-action\master\composite/../publish_unit_test_results.py", line 201, in <module>
      main(settings)
    File "D:\a\_actions\EnricoMi\publish-unit-test-result-action\master\composite/../publish_unit_test_results.py", line 52, in main
      files = [str(file) for file in pathlib.Path().glob(settings.files_glob)]
    File "D:\a\_actions\EnricoMi\publish-unit-test-result-action\master\composite/../publish_unit_test_results.py", line 52, in <listcomp>
      files = [str(file) for file in pathlib.Path().glob(settings.files_glob)]
    File "C:\hostedtoolcache\windows\Python\3.7.9\x64\lib\pathlib.py", line 1123, in glob
      raise NotImplementedError("Non-relative patterns are unsupported")
  NotImplementedError: Non-relative patterns are unsupported
  Error: Process completed with exit code 1.

You can see the full action run here if it helps: https://github.com/jonathanmedd/BricksetModule/runs/2323106971?check_suite_focus=true

EnricoMi · 2021-04-12T13:46:25Z

@jonathanmedd thanks for testing this. Looks like your files: "${{ github.workspace }}/tools/testResults.xml" pattern is problematic. Can you try:

files: "${{ github.workspace }}\\tools\\testResults.xml"
files: "tools/testResults.xml"

jonathanmedd · 2021-04-12T14:56:55Z

Tried both:

files: "${{ github.workspace }}\\tools\\testResults.xml" 👎
files: "tools/testResults.xml" 👍

So all is now good, thanks!

EnricoMi · 2021-04-12T19:14:02Z

Looks like Python prefers forward slashes on all OS and can translate it as required. Nice! This proves my README right :-)

Thanks for confirming it works for you.

WimLeflere · 2021-04-14T08:00:59Z

Nice work adding Windows and Mac support.

I was using composite@v1 from the README which doesn't work yet, as not yet released on v1.
Switched to master for now.

EnricoMi · 2021-04-16T06:20:36Z

@WimLeflere thanks for testing!

EnricoMi · 2021-04-16T06:22:17Z

This has been released, so it is available now as documented in the README.md via

uses: EnricoMi/publish-unit-test-result-action/composite@v1

Thanks for the patience.

jozza3000 · 2022-04-14T21:19:13Z

running on a windows selfhosted machine, getting this error:-

Run EnricoMi/publish-unit-test-result-action/composite@v1
o '##[group]Check for Python3'
echo '##[group]Check for Python3'
shell: C:\WINDOWS\system32\bash.EXE --noprofile --norc -e -o pipefail {0}
env:
JAVA_HOME: C:\actions-runner_work_tool\Java_Temurin-Hotspot_jdk\16.0.2-7\x64

/bin/bash: C:actions-runner_work_temp816f90e7-306e-4145-a6a6-e890e998056b.sh: No such file or directory
Error: Process completed with exit code 1.

EnricoMi · 2022-04-14T21:25:07Z

@jozza3000 Please see #211.

EnricoMi added the enhancement New feature or request label Sep 17, 2020

EnricoMi changed the title ~~Container action is only supported on Linux~~ Make action work on all OS Sep 17, 2020

EnricoMi closed this as completed Apr 16, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make action work on all OS #19

Make action work on all OS #19

joshrlesch commented Sep 16, 2020

EnricoMi commented Sep 17, 2020 •

edited

Loading

joshrlesch commented Sep 17, 2020

EnricoMi commented Sep 17, 2020

EnricoMi commented Sep 25, 2020

EnricoMi commented Oct 10, 2020

joshrlesch commented Oct 12, 2020

EnricoMi commented Oct 12, 2020

joshrlesch commented Oct 12, 2020

EnricoMi commented Oct 12, 2020

jonathanmedd commented Feb 9, 2021

EnricoMi commented Feb 16, 2021 •

edited

Loading

EnricoMi commented Feb 16, 2021 •

edited

Loading

jonathanmedd commented Feb 16, 2021

wildmichael commented Apr 9, 2021

EnricoMi commented Apr 11, 2021

jonathanmedd commented Apr 12, 2021

EnricoMi commented Apr 12, 2021

jonathanmedd commented Apr 12, 2021

EnricoMi commented Apr 12, 2021

WimLeflere commented Apr 14, 2021

EnricoMi commented Apr 16, 2021

EnricoMi commented Apr 16, 2021

jozza3000 commented Apr 14, 2022

EnricoMi commented Apr 14, 2022

Make action work on all OS #19

Make action work on all OS #19

Comments

joshrlesch commented Sep 16, 2020

EnricoMi commented Sep 17, 2020 • edited Loading

joshrlesch commented Sep 17, 2020

EnricoMi commented Sep 17, 2020

EnricoMi commented Sep 25, 2020

EnricoMi commented Oct 10, 2020

joshrlesch commented Oct 12, 2020

EnricoMi commented Oct 12, 2020

joshrlesch commented Oct 12, 2020

EnricoMi commented Oct 12, 2020

jonathanmedd commented Feb 9, 2021

EnricoMi commented Feb 16, 2021 • edited Loading

EnricoMi commented Feb 16, 2021 • edited Loading

jonathanmedd commented Feb 16, 2021

wildmichael commented Apr 9, 2021

EnricoMi commented Apr 11, 2021

jonathanmedd commented Apr 12, 2021

EnricoMi commented Apr 12, 2021

jonathanmedd commented Apr 12, 2021

EnricoMi commented Apr 12, 2021

WimLeflere commented Apr 14, 2021

EnricoMi commented Apr 16, 2021

EnricoMi commented Apr 16, 2021

jozza3000 commented Apr 14, 2022

EnricoMi commented Apr 14, 2022

EnricoMi commented Sep 17, 2020 •

edited

Loading

EnricoMi commented Feb 16, 2021 •

edited

Loading

EnricoMi commented Feb 16, 2021 •

edited

Loading