-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(refactor-ui): Refactor and Improve Auth Flows within UI #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13bfrancis
changed the title
basking
feat(refactor-ui): Refactor and Improve Auth Flows within UI
Jul 18, 2023
benjaminpaige
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is awesome. i know theres a failing action but we can fix that later if you want 👍
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is to redo the frontend to bring the flow closer to something that we currently want. We currently want to have a system where it is easy to manage authentication from within the frontend and steer users to where they need to be. We also added a un-protected home page route to bring the web application closer to the norm. The current flow is limited in that it is a home page, and a dashboard. This will be expanded upon in the future as requirements get added.
Notes
This will be an on going process and nothing in here is meant to be final. The purpose of this PR is to provide a good starting point for future additions and a pattern that will make development easier.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-24563
https://qmacbis.atlassian.net/browse/OY2-24474