feat(assorted): Assorted changes for the v1 read only system #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Stuff * Add details pages * update chip-spa page * update chip-spa page * update chip-spa page * pushing pixels around * pushing pixels around * cleanup * add test
mdial89f
changed the title
mdial89f
reviewed
Aug 18, 2023
src/packages/shared-types/onemac.ts
Outdated
| @@ -1,9 +1,37 @@ | |||
| import { z } from "zod"; | |||
| import { s3ParseUrl } from "shared-utils/s3-url-parser"; | |||
|
|
|||
| export enum ComponentType { | |||
There was a problem hiding this comment.
@benjaminpaige I think all of this can now be removed, in favor of getting the action type from the seatool data.
mdial89f
reviewed
Aug 18, 2023
| @@ -0,0 +1,26 @@ | |||
| import { ComponentType } from "shared-types"; | |||
|
|
|||
| export const componentLabel = { | |||
There was a problem hiding this comment.
If this map is still required to make things look nice, we should make sure its updated to reflect what action types (set by seatool) map to what labels. be nice if we could go without it somehow
There was a problem hiding this comment.
yes, done and done
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This branch holds various fixes for the read only initial release. The tickets and other issues are shown below.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-24970
https://qmacbis.atlassian.net/browse/OY2-24832
https://qmacbis.atlassian.net/browse/OY2-24835
https://qmacbis.atlassian.net/browse/OY2-24759
Other questions this answer or fixes: