-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(assorted): Assorted changes for the v1 read only system #86
Conversation
* Stuff * Add details pages * update chip-spa page * update chip-spa page * update chip-spa page * pushing pixels around * pushing pixels around * cleanup * add test
src/packages/shared-types/onemac.ts
Outdated
@@ -1,9 +1,37 @@ | |||
import { z } from "zod"; | |||
import { s3ParseUrl } from "shared-utils/s3-url-parser"; | |||
|
|||
export enum ComponentType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjaminpaige I think all of this can now be removed, in favor of getting the action type from the seatool data.
@@ -0,0 +1,26 @@ | |||
import { ComponentType } from "shared-types"; | |||
|
|||
export const componentLabel = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this map is still required to make things look nice, we should make sure its updated to reflect what action types (set by seatool) map to what labels. be nice if we could go without it somehow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, done and done
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Purpose
This branch holds various fixes for the read only initial release. The tickets and other issues are shown below.
Linked Issues to Close
https://qmacbis.atlassian.net/browse/OY2-24970
https://qmacbis.atlassian.net/browse/OY2-24832
https://qmacbis.atlassian.net/browse/OY2-24835
https://qmacbis.atlassian.net/browse/OY2-24759
Other questions this answer or fixes: