-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add location fields validation #50
Comments
I would go even further and make it choice fields down to city level |
I think it would be to complicated - should we support adding unexisting cities / regions? We definately need some research or guadiance by someone who tested location libraries. I know only Let's wait for others, maybe they will have better ideas? |
Why support adding unexisting places? |
I guess there is no lib that guarantees having full support for location names. It will be quite likely we would need to support adding Kozia Wólka or other places we won't have in lib database. |
Google Geocoding API should be OK. We might want to use GPS coordinates as well when adding a new station to reduce the number of mistakes. Also this: https://www.mjt.me.uk/posts/falsehoods-programmers-believe-about-addresses/ |
Couple of libs I checked were backed by official national location names databases. They supported every location that was official. |
@zen can You recommend any location lib for django You would use? What was the result of Your research? PS: So I see You do not want to support adding any location that is not in chosen lib. |
Unfortunately I don't remember what libraries I was checking. As for adding locations, I don't have hard opinion here, but I think it would be easier to use some library and only allow existing placed to be added |
As stated by @zen we could add some validation for location fields in Station and Project models.
My idea would be use Google Maps Geocoding API to verify if given location exists I don't know how reliable it would be.
@grillazz @khasinski @zen any other ideas?
The text was updated successfully, but these errors were encountered: