Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme hard-codes assumption that the backing ILS is Evergreen #17

Open
gmcharlt opened this issue Jun 6, 2024 · 0 comments
Open

Theme hard-codes assumption that the backing ILS is Evergreen #17

gmcharlt opened this issue Jun 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@gmcharlt
Copy link
Member

gmcharlt commented Jun 6, 2024

Commit 31a81c4 directly refers to data structures that are provided only by the Evergreen ILS driver to display the circulating library name and any monograph parts associated with an item. As a consequence, the theme will not correct display holdings from (say) Koha.

At minimum, the Evergreen-specific behavior should be behind an check of the active ILS driver(s). Better yet would be teaching the ILS driver to include parts when it provides call numbers to the theme.

@gmcharlt gmcharlt added the bug Something isn't working label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant