Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early fixes #3

Merged
merged 8 commits into from
Mar 13, 2024
Merged

Early fixes #3

merged 8 commits into from
Mar 13, 2024

Conversation

Eragoneq
Copy link
Collaborator

@Eragoneq Eragoneq commented Mar 8, 2024

All the existing tests are passing, but may need further review and some additional testing.

Closes #1

@iiljkic
Copy link
Collaborator

iiljkic commented Mar 9, 2024

http://www.bittorrent.org/beps/bep_0029.html check the section regarding the handshake where the seq number is initialized to an random value.

@Eragoneq
Copy link
Collaborator Author

Eragoneq commented Mar 9, 2024

http://www.bittorrent.org/beps/bep_0029.html check the section regarding the handshake where the seq number is initialized to an random value.

You're right, now I have noticed that the example code in the issue that the notion of client and server is reversed. As the server writes the data and client reads it, this is why the code expects 1 as the sequence number.

@tbocek
Copy link
Collaborator

tbocek commented Mar 11, 2024

Nice to see this kind of improvement!

@Eragoneq
Copy link
Collaborator Author

With no real breaking changes to the logic of the code, I will merge the current changes.
Further changes should be reviewed.

@Eragoneq Eragoneq merged commit 65c9b19 into master Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArrayIndexOutOfBoundsException
3 participants