Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios10和11上运行示例,load success后继续执行出错:"TypeError: Value is not a sequence" on Safari of ios10 and ios11 #35

Closed
Susy123 opened this issue Jul 21, 2020 · 8 comments

Comments

@Susy123
Copy link

Susy123 commented Jul 21, 2020

在ios10和ios11的safari上运行示例https://qiaozi-tech.github.io/WXInlinePlayer/example/index.html;load success后抛出错误"TypeError: Value is not a sequence",不能正常播放。
image

@ErosZy
Copy link
Owner

ErosZy commented Jul 21, 2020

手上的机器没有问题,有error stack么?截图截全一点。

@Firstnote
Copy link
Contributor

同样的问题,在index中 this.emit("mediaInfo", t.data)之后,另一个进程的onmessage触发时会报这个错

@Susy123
Copy link
Author

Susy123 commented Jul 22, 2020

browserstack上这个测试过可以复现问题。
image

@ErosZy
Copy link
Owner

ErosZy commented Jul 22, 2020

will fix in 1.3.3

@Susy123
Copy link
Author

Susy123 commented Jul 22, 2020

请求提示一下大致思路,🤣尝试本地先修复用一下 @ErosZy

@ErosZy
Copy link
Owner

ErosZy commented Jul 22, 2020

@Susy123
Copy link
Author

Susy123 commented Jul 24, 2020

调试了一下,问题确实出在postMessage,第二个参数在ios10和11上不支持null,换成undefined即可;位置在:
https://github.com/qiaozi-tech/WXInlinePlayer/blob/1ce82c59b408c8e5feb06fdb48a4002bda2aa8bb/lib/codec/combine/glue.js#L139

https://github.com/qiaozi-tech/WXInlinePlayer/blob/1ce82c59b408c8e5feb06fdb48a4002bda2aa8bb/lib/codec/combine/glue.js#L97

image

(感谢 @Firstnote 协同定位修复问题)

@ErosZy
Copy link
Owner

ErosZy commented Jul 24, 2020

@Susy123 可以提个PR么?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants