Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CX_CLEANUP] - Test the dependency verifications #2711

Closed
Tracked by #3265
shenkeyao opened this issue Mar 6, 2024 · 0 comments
Closed
Tracked by #3265

[CX_CLEANUP] - Test the dependency verifications #2711

shenkeyao opened this issue Mar 6, 2024 · 0 comments

Comments

@shenkeyao
Copy link
Member

shenkeyao commented Mar 6, 2024

What is this task and why do we need to work on it?

  • Previous sad-path tests added in [CX_CLEANUP] - Test the dependency framework #2709 should still work.
  • Sad path: Add unit tests to verify that we don’t receive a QuorumVoteRecv event if any verification fails.
  • Happy path: Update the previous happy-path test with the correct event fields and verify that we receive a QuorumVoteRecv.

What work will need to be done to complete this task?

No response

Are there any other details to include?

Design doc: https://www.notion.so/espressosys/Refactor-Voting-Logic-9afa14dd027d453aa9b4a80a52de5e44.

What are the acceptance criteria to close this issue?

Tests pass.

Branch work will be merged to (if not the default branch)

No response

@shenkeyao shenkeyao self-assigned this Mar 6, 2024
@shenkeyao shenkeyao changed the title [CX_CLEANUP] - Test the dependency verifications. [CX_CLEANUP] - Test the dependency verifications Mar 6, 2024
@jparr721 jparr721 closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants