Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix large shares when small payload and large multiplicity #663

Closed
akonring opened this issue Aug 20, 2024 · 1 comment · Fixed by #670
Closed

Fix large shares when small payload and large multiplicity #663

akonring opened this issue Aug 20, 2024 · 1 comment · Fixed by #670

Comments

@akonring
Copy link
Contributor

In many settings it may be advantageous to configure the VID scheme to use large multiplicity.
However, the current implementation of the ADVZ scheme will force polynomials to be of size multiplicity * recovery_threshold even for small payloads.
Instead, the disperse function should use the lowest value for multiplicity such that payload_len $$\leq$$ multiplicity * recovery_threshold.

@ggutoski
Copy link
Contributor

There are lots of ways to solve this problem, but all of them are bad ergonomics. After some discussion we decided the least bad solution is what's suggested by OP: silently use the smallest multiplicity needed to fit the entire payload into a single polynomial. We'll rename multiplicity -> max_multiplicity and update docs to explain that this arg allows the caller to specify only the maximum multiplicity that can be used for dispersal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants