Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing event before export request in dynamicMapLayer #1146

Closed
ogix opened this issue Mar 26, 2019 · 2 comments
Closed

Missing event before export request in dynamicMapLayer #1146

ogix opened this issue Mar 26, 2019 · 2 comments

Comments

@ogix
Copy link
Contributor

ogix commented Mar 26, 2019

Now when using dynamicMapLayer, 'loading' event fires only after export request which sometimes takes quite long. So it is not possible to show a loader before export request happens.
It would be very useful to fire 'loading' event (or introduce another event) before export request.
@ogix ogix changed the title Missing event before export in dynamicMapLayer Missing event before export request in dynamicMapLayer Mar 26, 2019
@jgravois
Copy link
Contributor

this event was added in #148

'loading' event fires only after export request

i agree that it'd be more helpful if 'loading' fired immediately before /export is called. would you be willing to contribute a pull request of your own?

@ogix ogix mentioned this issue Mar 28, 2019
Merged
@ogix
Copy link
Contributor Author

ogix commented Mar 28, 2019

I made a PR. Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ogix @jgravois