Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esri attribution removes custom Leaflet prefix #1361

Closed
markconnellypro opened this issue May 12, 2023 · 0 comments · Fixed by #1366
Closed

Esri attribution removes custom Leaflet prefix #1361

markconnellypro opened this issue May 12, 2023 · 0 comments · Fixed by #1366

Comments

@markconnellypro
Copy link

Describe the bug

When Esri Leaflet adds Powered by Esri to the attribution, it overwrites the preexisting attribution prefix.

I submitted pull request #1360 to address this. This pull request changes this process to retrieve the existing attribution prefix first, so that it can be used in lieu of the constant when overwriting and so that it can be restored in the event that all Esri layers are moved from the map display.

Reproduction

In this sample, the state layer hosted by Esri is loaded on page load, and the custom prefix is not included at all, despite being included in the code:

https://output.jsbin.com/habugazata/1/

In this sample, the custom prefix is displayed when the page is loaded, but is overwritten when the state layer hosted by Esri is loaded, and is not restored if removed:

https://output.jsbin.com/habugazata/2/

Logs

No response

System Info

Leaflet: 1.9.3
Esri Leaflet: 3.0.10

Additional Information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant