Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compileOnSave when *.js file in files:[] array changes #149

Open
dehart opened this issue Apr 1, 2019 · 0 comments
Open

compileOnSave when *.js file in files:[] array changes #149

dehart opened this issue Apr 1, 2019 · 0 comments

Comments

@dehart
Copy link

dehart commented Apr 1, 2019

The typescript compiler has an "allowJs" option. However *.js files are not part of the project so compileOnSave will not be triggered for the *.js files.

I had a look at TSIndexerFactory:: createIndexer() and found that it would only index tsconfig.json and *.ts files.

If it also indexes all *.js files or just the *.js files specified inside the files tsconfig option. compileOnSave would work for the include *.js files as well.

I think this issue was reported for VS2015 and fixed in VS2017
microsoft/TypeScript#14536 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant