Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kerAliasesNotSupported: Please send this XMP packet to ... #1404

Open
moon6969 opened this issue Nov 21, 2020 · 1 comment
Open

kerAliasesNotSupported: Please send this XMP packet to ... #1404

moon6969 opened this issue Nov 21, 2020 · 1 comment
Labels
refactoring Cleanup / Simplify code -> more readable / robust
Milestone

Comments

@moon6969
Copy link

moon6969 commented Nov 21, 2020

kerAliasesNotSupported
N_("Aliases are not supported. Please send this XMP packet to ahuggel@... %1', %2', `%3'") },

Is Andreas still interested in these!?

I wonder if it should instead refer users to raise a Github issue? If not, just "Aliases are not supported".

@moon6969 moon6969 changed the title kerAliasesNotSupported: Please send this XMP packet to [email protected] kerAliasesNotSupported: Please send this XMP packet to ... Nov 21, 2020
@clanmills
Copy link
Collaborator

clanmills commented Nov 21, 2020

Yes. "Aliases are not supported" is sufficient. In the XMP Spec XMPSpecificationPart2.pdf it says (incomprehensibly):

Previous versions of this specification referred to aliased properties. Specific XMP implementations may treat a property in one namespace as equivalent to a property in another namespace. However, to foster interchange, applications must always write the standard, “base” form of the property. In this version of the specification, only the base properties are listed.

Alison and I visited and stayed with Andreas and family in 2016. Andreas has lost all interest in Exiv2. Time to scrub his name from the code. I have given him huge praise in the book. His implementation of the TiffVisitor is very robust and thorough.

I feel scrubbing the code prologs is something we should do towards the end of releasing Exiv2 v0.28. Possibly at RC2. I know that @piponazo would like to reformat all the code using clang based tools. While we have two shipping branches (0.27-maintenance and master) we have not done this. However if we ship v0.28 and v0.27.4 in spring 2021, there will be few subsequent changes 0.27-maintenance (if ever). We haven't had a CVE raised on Exiv2 for more than a year. There are no open security issues on Exiv2.

1049 rmills@rmillsmm-local:~/gnu/github/exiv2/0.27-maintenance $ find . -type f -name "*pp" | xargs grep ahuggel
./include/exiv2/crwimage.hpp:           <a href="mailto:[email protected]">[email protected]</a>
./include/exiv2/futils.hpp:           <a href="mailto:[email protected]">[email protected]</a>
...
./src/actions.hpp:           <a href="mailto:[email protected]">[email protected]</a>
./src/convert.cpp:  Author(s): Andreas Huggel (ahu) <[email protected]>
./src/fujimn_int.hpp:           <a href="mailto:[email protected]">[email protected]</a>
./src/error.cpp:          N_("Aliases are not supported. Please send this XMP packet to [email protected] `%1', `%2', `%3'") }, // %1=namespace, %2=property path, %3=value
./src/samsungmn_int.cpp:  Author(s): Andreas Huggel (ahu) <[email protected]>
./src/tiffvisitor_int.cpp:  Author(s): Andreas Huggel (ahu) <[email protected]>
./src/rafimage.cpp:  Author(s): Andreas Huggel (ahu) <[email protected]>
...

For that matter, all contributors names should be scrubbed. Gilles, Brad and others have credited themselves in code prologs. Author/Contributors are stored in the source code history.

I've listed the copyright notices in the code (other than "Exiv2 authors") are (and seem legitimate). As Brad, Andreas and Johannes are "Exiv2 authors", we could (but won't) modify those notes. Moreover, these three are in contrib or sample code and therefore don't impact the library. So the copyright notices seem legitimate.

contrib/organize/organize.cpp: * Copyright (C) 2009 Brad Schick <[email protected]>
samples/toexv.cpp: * Copyright (C) 2004-2017 Andreas Huggel <[email protected]>
samples/Jzon.cpp:Copyright (c) 2013 Johannes Häggqvist
xmpsdk/include/client-glue/TXMPIterator.incl_cpp:// Copyright 2002-2007 Adobe System

@clanmills clanmills added this to the v1.00 milestone Apr 12, 2021
@clanmills clanmills added the refactoring Cleanup / Simplify code -> more readable / robust label Apr 13, 2021
@kevinbackhouse kevinbackhouse modified the milestones: v0.28.0, Backlog Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleanup / Simplify code -> more readable / robust
Projects
None yet
Development

No branches or pull requests

3 participants