Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for alpha bit detection in VP8L chunks #565

Open
piponazo opened this issue Nov 26, 2018 · 2 comments
Open

Test for alpha bit detection in VP8L chunks #565

piponazo opened this issue Nov 26, 2018 · 2 comments
Labels
refactoring Cleanup / Simplify code -> more readable / robust
Milestone

Comments

@piponazo
Copy link
Collaborator

In #559 @skal65535 contributed a patch to fix the alpha bit detection in VP8L chunks. He provided a reproduction case that we should add in the python test suite.

@clanmills clanmills added this to the v1.00 milestone Apr 13, 2021
@clanmills
Copy link
Collaborator

Wow. This dropped "below the radar". Let's see if we can get this fixed in v1.00.

@clanmills clanmills added refactoring Cleanup / Simplify code -> more readable / robust and removed good first issue labels Apr 13, 2021
@norbertwg
Copy link
Contributor

I wanted to take care about this issue - but have some difficulties.
The original issue was, that a file did not open in Gimp. skal65535 found as root cause that the alpha bit was not set correct. Did I get this right?
My question now is, how this could be included in the test suite. Based on the original issue, it should be tested, if the file modified with the command skal65535 documented, can be opened by Gimp. But I do not think that this is possible - or at least have doubts if the effort to test with Gimp on different platforms is worth it.
Or is the idea to have just a test, that the flag is set correct?

@kevinbackhouse kevinbackhouse modified the milestones: v0.28.0, Backlog Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleanup / Simplify code -> more readable / robust
Projects
None yet
Development

No branches or pull requests

4 participants