Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting port, config file and tui via env vars #46

Closed
adrian-gierakowski opened this issue Feb 19, 2023 · 8 comments
Closed

allow setting port, config file and tui via env vars #46

adrian-gierakowski opened this issue Feb 19, 2023 · 8 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@adrian-gierakowski
Copy link
Contributor

for example:

PROC_C_PORT=9999 process-compose

instead of:

process-compose -p 9999

why?

This could be set by tools like direnv or devenv so that when I'm working on multiple projects, I can have multiple instances of process-compose running on different ports, and when I enter each project dir, appropriate env vars are set so that I can simply run process-compose in the project dir and it will know on which port it should be running without me having to provide the argument manually with correct port on each invocation.

@F1bonacc1
Copy link
Owner

Hi @adrian-gierakowski,

Sounds like a good proposal.
I will add it to the next release.

@F1bonacc1 F1bonacc1 added enhancement New feature or request good first issue Good for newcomers labels Feb 20, 2023
@adrian-gierakowski
Copy link
Contributor Author

Thanks!

@adrian-gierakowski
Copy link
Contributor Author

Btw would it make sense to also add an env var for the config file path(s)?

@F1bonacc1
Copy link
Owner

It's in the title, so yeah, already added that.
Will be part of the next release.

@adrian-gierakowski
Copy link
Contributor Author

It's in the title, so yeah, already added that.
Will be part of the next release.

Lol, I must have had not enough sleep. Thanks!

@F1bonacc1
Copy link
Owner

Hey @adrian-gierakowski

Please let me know if v0.43.1 works for you as expected.

@adrian-gierakowski
Copy link
Contributor Author

Will do, thanks a lot!

@F1bonacc1
Copy link
Owner

Please create a new issue if anything is not as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants