Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues spotted in the NOMAD Oasis EM/EBSD example #20

Open
2 of 6 tasks
mkuehbach opened this issue May 29, 2024 · 0 comments
Open
2 of 6 tasks

Issues spotted in the NOMAD Oasis EM/EBSD example #20

mkuehbach opened this issue May 29, 2024 · 0 comments
Labels
question Further information is requested

Comments

@mkuehbach
Copy link
Collaborator

mkuehbach commented May 29, 2024

Issues spotted with the 0.1 version of the EBSD database uploaded in @mkuehbach local oasis:
https://nomad-lab.eu/prod/v1/oasis/gui/ (filter entries via "entry_type = NXem" to see them all)

NeXus parsing:

  • nexus.py NeXus parser must not populate chemical formulas from instance data NXem/NXentry/sample/atom_types

Metainfo:

  • Uploads should not be assigned to metainfo.domain must not be "dft"
  • metainfo.references, metainfo.main_author, meta.info.coauthors are not filled with original authors but NXem/NXentry/NXcite instances are correct
  • results.material.chemical_formula*, implies it is for the entire piece of material, however not only in engineering the piece of material is a composite and thus what use is in reporting the "average temperature of all patients in a hospital? (L. Shvindlerman)?"
  • metainfo.main_author should be the person who uploads the dataset

Entries overview page:

  • Should these datasets be under domain-specific section, e.g. electron microscopy, like "Solar cells"
@mkuehbach mkuehbach added the question Further information is requested label Jun 5, 2024
@mkuehbach mkuehbach changed the title Issues spotted in the nomad OASIS EBSD example Issues spotted in the NOMAD Oasis EM/EBSD example Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant