Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify usage of MeshTags in Python interface #2348

Closed
jorgensd opened this issue Sep 6, 2022 · 1 comment
Closed

Unify usage of MeshTags in Python interface #2348

jorgensd opened this issue Sep 6, 2022 · 1 comment
Labels
documentation Documentation improvements or fixes enhancement New feature or request task A task to perform

Comments

@jorgensd
Copy link
Sponsor Member

jorgensd commented Sep 6, 2022

Currently we use a mixture of the MeshTagsMetaClass and the dolfinx::mesh::MeshTags<T> in the Python interface.

This causes issues when using explicit typing, for instance with mypy, see: #2219

We should make sure that all MeshTags used in Python is wrapped with the meta-class.
@jorgensd jorgensd added enhancement New feature or request documentation Documentation improvements or fixes labels Sep 6, 2022
@jorgensd jorgensd mentioned this issue Sep 6, 2022
Closed
@garth-wells garth-wells added the task A task to perform label Jan 28, 2023
@garth-wells
Copy link
Member

Fixed in #2522.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Documentation improvements or fixes enhancement New feature or request task A task to perform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garth-wells @jorgensd