Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow fail silently #147

Open
KelvinChung2000 opened this issue Feb 2, 2024 · 2 comments
Open

Workflow fail silently #147

KelvinChung2000 opened this issue Feb 2, 2024 · 2 comments

Comments

@KelvinChung2000
Copy link
Contributor

After the changes in #130, the GitHub action will fail to detect errors during the execution of any command since the shell will catch the error and prevent it from propagating to the action. The GitHub action will require updates to avoid situations like this happening.

@TaoBi22
Copy link
Contributor

TaoBi22 commented Feb 12, 2024

Good point! Any suggestions for how to do this? grepping for error messages seems a little fragile

@KelvinChung2000
Copy link
Contributor Author

Maybe we can remove the ./build_test_design.sh at the smoke test and force to use the synthesis result and the place and route result from the CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants