-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Formatter #158
Comments
Formatting and style guides are things that need work on. I am using a heavily modified autopep8. Is there an easy way to set up the style? i.e. after cloning, can the code automatically apply to the style guide with an editor like vscode? |
Well, you can just install black via pip: I don't use vscode, but there seems to exist an extension for it: Black Formatter. Support for other editors does exist too. I can take a look at integrating black with the FABulous codebase. Basically the CI runs black and fails if the code has not been formatted. If desired, reviewdog can create comments on the PR with the necessary changes. Or the developer can just fix it themselves by running black. |
Hi, this could be closed since we use black in the GitHub actions, right? :) |
My bad, forgot that this is still only in the dev branch. Sorry for the disturbance. |
No worries! Any news on when dev will be merged? |
Unfortunately I don't know anything about when the merge is targeted :/ |
I am trying to push a stable release with what we have now. I really would like this done asap, ideally weeks after the summer school. Otherwise, another workshop might come up, and we once again need to delay this |
Use a code formatter to format the codebase.
Before any discussions come up about which coding style to use, I would suggest just to use Black:
The text was updated successfully, but these errors were encountered: