Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persistent command line history not working on FABulous2.0 branch #230

Open
IAmMarcelJung opened this issue Aug 28, 2024 · 3 comments
Open

Comments

@IAmMarcelJung
Copy link
Contributor

When testing the edits made in the recent pull requests, I noticed that the persistent CLI history (being able to recall commands from previous FABulous sessions) introduced in #132 did not work anymore in the FABulous2.0 branch. It still does work for me in the master branch. Can anyone confirm or deny this behaviour? If it can be confirmed, was it removed on purpose or by accident?

Thanks in advance for any help!

@KelvinChung2000
Copy link
Contributor

I have experienced the same, and it is likely by accident.

@IAmMarcelJung
Copy link
Contributor Author

Thanks for your feedback, then it is a bug and should be fixed at some time. I do not have the time currently but if it will not be fixed for some time I might look into this. But since it's just a nice-to-have and nothing critical, it is not urgent.

Still, it shows that we might need better testing if features get broken by code updates. But I think this is already known and we just don't have the resources to do so.

@KelvinChung2000
Copy link
Contributor

When I am working on the release, I will spend some time using LLM to generate tests for the software.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants