diff --git a/lib/libfrr.c b/lib/libfrr.c index 0a575abac6cd..b209e4d602a4 100644 --- a/lib/libfrr.c +++ b/lib/libfrr.c @@ -1125,8 +1125,8 @@ static void frr_terminal_close(int isexit) * don't redirect when stdout is set with --log stdout */ for (fd = 2; fd >= 0; fd--) - if (isatty(fd) && - (fd != STDOUT_FILENO || !logging_to_stdout)) + if (!logging_to_stdout || !isatty(fd) || + fd != STDOUT_FILENO) dup2(nullfd, fd); close(nullfd); } @@ -1213,8 +1213,8 @@ void frr_run(struct event_loop *master) * stdout */ for (fd = 2; fd >= 0; fd--) - if (isatty(fd) && - (fd != STDOUT_FILENO || !logging_to_stdout)) + if (!logging_to_stdout || !isatty(fd) || + fd != STDOUT_FILENO) dup2(nullfd, fd); close(nullfd); }