Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorful Enchantments causes rendering enchanted books to crash in ponder #1011

Open
LizzieSpace opened this issue Jul 22, 2023 · 1 comment
Labels
area: compatibility Issue only happens when other mods are present status: needs testing Issue needs testing type: bug Issue where something isn't working

Comments

@LizzieSpace
Copy link

Describe the Bug

Create mod seems to have rather specific issues when regarding modded textures, immediately crashing in some instances.
One of these instances is when trying to select a grass block with the creative world shaper item while playing with the Lambda's Better Grass mod, where it'll Immediately crash.

The crash that this report refers to, however, relates to Colorful Enchantments crashing when an enchanted book is rendered by the ponder system.

The issue above can be reproduced by a game with Create Enchantment Industry and Colorful Enchantments running alongside Create, as the default mod contains no listed ponder with the item (or so i believe)

Reproduction Steps

  1. start game
  2. enter ponder index
  3. navigate to experience related ponders
  4. ponder the enchanting guide
  5. move to the second scene: Enchanting
  6. watch the game immediately crash once the ponder system attempts to render the Enchantment book
  7. view logs
  8. restart the game
  9. repeat the process without Colorful Enchantments to see how the ponder behaves with the vanilla model
    ...

Expected Result

Both the ponder Index and the creative World Shaper should render modded textures normally OR fallback to a default texture, such as the vanilla models or a template missing texture to avoid crashes

Screenshots and Videos

Crash Report or Log

https://mclo.gs/NfPTYak

Operating System

Ubuntu 22.04.2 LTS

Mod Version

0.5.1b

Minecraft Version

1.19.2

Other Mods

  • Colorful Enchantments
  • Create
    • Create Enchantment Industry
  • Debugify
  • Fabric Api

Additional Context

This issue, as pointed out by the crash logs, seems to be directly related to the mechanisms behind how Create decides to render items. Due to the nature of it, it may cause plenty of unintended mod incompatibilities that could be avoided with proper methods.

@TropheusJ
Copy link
Member

LBG issue is known: #631

@TropheusJ TropheusJ changed the title Modded models being rendered by Create causes the game to crash Colorful Enchantments causes rendering enchanted books to crash in ponder Aug 4, 2023
@TropheusJ TropheusJ added the area: compatibility Issue only happens when other mods are present label Aug 18, 2023
@IThundxr IThundxr removed the 1.19 label Sep 18, 2024
@TropheusJ TropheusJ added the status: needs testing Issue needs testing label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: compatibility Issue only happens when other mods are present status: needs testing Issue needs testing type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants