Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Immersive Portals #53

Open
AeiouEnigma opened this issue Dec 24, 2021 · 19 comments
Open

Incompatibility with Immersive Portals #53

AeiouEnigma opened this issue Dec 24, 2021 · 19 comments
Labels
area: compatibility Issue only happens when other mods are present status: needs testing Issue needs testing type: bug Issue where something isn't working

Comments

@AeiouEnigma
Copy link

AeiouEnigma commented Dec 24, 2021

Describe the Bug

Create and Immersive Portals do not function together. In my testing, opening an Immersive portal either crashes the game outright or produces an extreme rendering glitch where whenever an Immersive portal is visible the renderer seems to wrongly behave as though the player is in the dimension on the opposite side of the portal.

Reproduction Steps

  1. Install Create and Immersive Portals
  2. Build an Obsidian frame
  3. Light the interior of the frame on fire using a Flint and Steel
  4. Wait for the portal to finish loading
  5. Either the game has now crashed or extreme rendering glitch is observed.

Expected Result

Normal Immersive Portals rendering behavior was expected

Screenshots and Videos

Looking through an Immersive portal from a snowy plains biome in the overworld:
image

Looking through the same portal from the nether:
image

Crash Report or Log

https://gist.github.com/AeiouEnigma/7d8a380b600b9259467967236627fb37

Operating System

Windows 11

Mod Version

0.4.0a

Minecraft Version

1.18.1

Other Mods

Architectury
Cloth Config
Fabric API
Flywheel
Immersive Portals
Modmenu
REI

Additional Context

Have a holly jolly Christmas

@AeiouEnigma AeiouEnigma added the type: bug Issue where something isn't working label Dec 24, 2021
@github-actions github-actions bot added the 1.18 label Dec 24, 2021
@github-actions
Copy link

This issue has been marked as stale because it has been inactive for 3 weeks. It will be closed if it remains inactive for another 3 weeks.

@github-actions github-actions bot added the stale label Jan 15, 2022
@AeiouEnigma
Copy link
Author

Uncertain whether the crash still occurs, but the rendering issue is alive and well.

@digitaltrucker
Copy link

Immersive Portals does now work with Create as long as you enable 'Compatibility Render Mode' in the client side settings of Immersive Portals.

@Nolij
Copy link

Nolij commented Apr 15, 2022

Immersive Portals does now work with Create as long as you enable 'Compatibility Render Mode' in the client side settings of Immersive Portals.

Is that any different in implementation from the command workaround? If not I might still consider this a bug.

@digitaltrucker
Copy link

It seems to have the same result. I suspect it's a settings implementation of the command? I'm not a coder so I can only go by behavior.

@qouteall
Copy link

qouteall commented May 7, 2022

It's weird that I don't see flywheel touch with framebuffer, stencil or post processing. Does Create use other dependency that touch rendering?

@TropheusJ
Copy link
Member

Create has some shaders, and Porting Lib has a ton of hooks, some into rendering

@qouteall
Copy link

qouteall commented May 13, 2022

@TropheusJ I wanted to debug this issue in create's dev env, but the dev env cannot launch MC (without any modification), saying missing com_electronwill_night-config_core and com_electronwill_night-config_toml .
(but these mods are in the dependency, maybe it's a loom bug)

I couldn't find you in the Fabric discord. What's your discord username?

@TropheusJ
Copy link
Member

You need the dependency override, maybe it wasn’t included some reason. You can find me on the Create discord or in the Quilt community discord as Tropheus Jay#7241

@qouteall
Copy link

In immptl 1.3.7 the crash and portal rendering issue is fixed. but the create things in remote dimensions may still not get rendered correctly until F3+A.

@KevlarBandit
Copy link

KevlarBandit commented Jul 18, 2022

I have done some testing and it appears that the mods are nearly compatible at this point.

As it stands, there are two issues. One, portals get pushed by contraptions and two, on actually traveling through the portal, the contraption is (sort of) broken leaving the blocks used to make it on one side of the portal and the contraption on the other side.

Using the "dimension stack" feature of immersive portals, the entity pushing problem can be bypassed. (Note, this is looking from the bottom of one dimension into the top of another, the netherrack is at the bottom most layer of the top dimension. Rendering appears to work fine.)
https://i.imgur.com/kYzreda.png

Horizontal portals are pushed like this: https://i.imgur.com/FAENw6J.png

Vertical portals allow the cart to travel through in some cases but "break" the cart up to three times leading to potentially triplicating the blocks used to create the cart.
https://i.imgur.com/Q0qhjIs.png
https://i.imgur.com/zgMOTLW.png

I so desperately want to be able to make trains that go through portals.

@nmurphy101
Copy link

@KevlarBandit Not sure if this would fix any other issue, but here's a link to a compatibility mod for immersive portals and create mod that someone made for 1.19.2 to get the trains working through portals:
https://www.dropbox.com/s/chay7nhip54ywge/immersive_trains-1.0.1.jar?dl=0
Original place it was posted: Sascha-T/tele-create#2

@KevlarBandit
Copy link

@KevlarBandit Not sure if this would fix any other issue, but here's a link to a compatibility mod for immersive portals and create mod that someone made for 1.19.2 to get the trains working through portals:
https://www.dropbox.com/s/chay7nhip54ywge/immersive_trains-1.0.1.jar?dl=0
Original place it was posted: Sascha-T/tele-create#2

Thank you for linking me.

I am the one who ported it. Let me know if you have problems. It has had problems but I have not been able to replicate then.

@IGN-Styly
Copy link

Tried to replicate, using lts and compatibility mode in immersive portals. Could not replicate.

@IGN-Styly
Copy link

Should assume closed?

@KevlarBandit
Copy link

Tried to replicate, using lts and compatibility mode in immersive portals. Could not replicate.

What version of each?

I'll try and take a look sometime in the next week.

It was broken in some serious ways and I can even explain in detail what was broken, but I haven't checked for about 2 months so it might well be the case that either immersive portals and/or create got an update that fixed it.

A good thing to test would be to drop a minecart contraption through a portal and to push a block through a portal using a piston contraption. Those two provided the worst problems.

@IGN-Styly
Copy link

tried 1.18.2 which is lts with immersive portal's lts

@KevlarBandit
Copy link

tried 1.18.2 which is lts with immersive portal's lts

What version of the mods?

@IGN-Styly
Copy link

lts

@IThundxr IThundxr removed the 1.18 label Sep 18, 2024
@TropheusJ TropheusJ added the status: needs testing Issue needs testing label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: compatibility Issue only happens when other mods are present status: needs testing Issue needs testing type: bug Issue where something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants