[Bug]: Optifine (D6) crash with Triangulator 1.4.3

[SilearFlare]

OS

Linux/BSD

GPU

AMD

Modpack (Optional)

No response

Game log

https://paste.ee/p/wRtVR

Description

Testing on an empty instance, the latest version of Triangulator crashes at startup with optifine added. I've attached the crash.

Edit:
This, for some reason, does not seem to happen with Optifine version E7. Testing with Tesselator 1.4.3 + Optifine E7, there are no crashes. This is a problem, because E7 has exponentially less cross-mod compatibility than D6 and a much lower performance improvement because of the merging with the Shaders mod ages ago (Optifine D6 is the last version of the mod for 1.7 before the merge and thus the go-to version for anyone who doesn't use shaders.)

As always, thanks for all help on the subject.

[embeddedt]

E7 has exponentially less cross-mod compatibility than D6 and a much lower performance improvement

This isn't directly related to the issue, but do you have a source for this, and is it still true if you do not enable shaders? I've used E7 for quite some time and haven't seen any compatibility issues. If this is true, I would definitely consider downgrading to D6.

[SilearFlare]

do you have a source for this, and is it still true if you do not enable shaders? I've used E7 for quite some time and haven't seen any compatibility issues. If this is true, I would definitely consider downgrading to D6.

Sure. The real main issue with E7 (other than general poorer performance) is the lost compatibility with fastcraft 1.2.3. I'll explain.
The short version is directly explained in the fastcraft's download itself, but the vague wording doesn't really give it justice. Basically, you get a large FPS boost (in my case ranging roughly to 10-20+ additional fps) with fastcraft 1.2.3 compared to 1.2.5. Basically Player didn't really want to mess around with trying to fixing issues in a closed source mod for what in 2018 was already considered an ancient version, so he just ripped the offending parts apart from his mod until it stopped crashing with optifine.

Adding default compat with the shaders mod required gutting a lot of the parts of fastcraft that had been jiggled together to work with optifine. Because of that fastcraft 1.2.3 outright crashes with newer version of optifine, but the cost of native shader support is a hefty FPS penalty compared to the original.

As it stands I can conjure a few random screenshots of similarly anecdotal evidence if needed, but if we stick to the provable facts adding shaders compat meant a worse performance overall + loss of support for critical fastcraft infrastructure which made the problem worse. That's the long and short of it basically. I invite you to test that yourself (albeit, without tesselator for the time being 😅) to see the difference.

In the meantime, since I was having a discussion with some people about this specific issue, I did some pretty thorough testing that I thought I might post by standing very still for a few minutes with peaceful settings waiting for chunks to load while looking at the same spot towards the horizon in the same world between tests to get repeatable results: In an empty instance with only optifine D6 + fastcraft 1.23 or optfine E7 + fastcraft 1.25 are equivalent. See:
D6 + fastcraft 1.23, empty instance
E7 + fastcraft 1.25, empty instance
This however changed radically when applied to a 1.7 modpack with 200 + mods I've been playing it for the last few years, Optifine D6 had an average of 30 to 35 FPS:
30-35 FPS D6 + fastcraft 1.23, modpack
while Optifine E7 had an average of 10 to 15, sometimes dipping in the single digits:
10-15 FPS E7 + fastcraft 1.25, modpack
8 FPS

So in short: and I'm sorry for going so far astray from the topic here, but D6 basically mogs E7 in a modded setting, and I hope this issue with triangulator can be fixed for D6 too!

[FalsePattern]

I found the issue, long story short: the current optifine compatibility tweaks in triangulator only look for optifine version with the shadersmod integrated, but this assumption was unfortunately wrong, and the "triangle soup" fix in 1.4.1 conflicts with older optifine versions too.
I'm working on fixing this right now

[FalsePattern]

Should be fixed in 1.4.4

[SilearFlare]

Confirmed, I've run the pack properly with 1.4.4 and haven't noticed any issue!
Thank you very much for your work 🥳