From 85d9cf6f435144386775eba500f5b99f964902af Mon Sep 17 00:00:00 2001 From: Tatu Saloranta Date: Sun, 15 Jan 2023 19:02:47 -0800 Subject: [PATCH] Fix "failing failing" test for #396 --- .../kotlin/test/github/{failing => }/Github396.kt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) rename src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/{failing => }/Github396.kt (72%) diff --git a/src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/failing/Github396.kt b/src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/Github396.kt similarity index 72% rename from src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/failing/Github396.kt rename to src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/Github396.kt index 57939371..ecbac8c6 100644 --- a/src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/failing/Github396.kt +++ b/src/test/kotlin/com/fasterxml/jackson/module/kotlin/test/github/Github396.kt @@ -9,7 +9,9 @@ import kotlin.test.assertEquals class TestGithub396 { /** - * Succeeds in Jackson 2.11.x, but fails in Jackson 2.12.0 + * Succeeds in Jackson 2.11.x, but fails in Jackson 2.12.0. + * But succeeds again in 2.15.0. + * * See https://github.com/FasterXML/jackson-module-kotlin/issues/396 */ @Test @@ -17,11 +19,9 @@ class TestGithub396 { val mapper = XmlMapper().registerKotlinModule() val xml = "" - expectFailure("GitHub #396 has been fixed!") { - val product: Product = mapper.readValue(xml, Product::class.java) + val product: Product = mapper.readValue(xml, Product::class.java) - assertEquals(Product(null), product) - } + assertEquals(Product(Stuff(null)), product) } private data class Stuff(val str: String?)