Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode methods should accept []byte #21

Open
AlekSi opened this issue Nov 27, 2023 · 0 comments · May be fixed by #36
Open

Encode methods should accept []byte #21

AlekSi opened this issue Nov 27, 2023 · 0 comments · May be fixed by #36
Assignees
@noisersup
Labels
code/perf Performance improvements

Comments

@AlekSi
Copy link
Member

AlekSi commented Nov 27, 2023 •
edited
Loading

Document.Encode and Array.Encode should accept a byte slice, not return it. Since the caller always knows the needed slice length (by calling size), this could allow for optimizing allocations by using memory pools, etc.

Run benchmarks before and after, and show benchstat output.
@AlekSi AlekSi added code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Nov 27, 2023
@AlekSi AlekSi assigned AlekSi and unassigned ferretdb-bot Dec 26, 2023
@AlekSi AlekSi mentioned this issue Jan 4, 2024
Merged
9 tasks
AlekSi referenced this issue in FerretDB/FerretDB Jan 17, 2024
@AlekSi
Add new BSON decoding package (#3905)
562d767 
Closes #3759.
@AlekSi AlekSi reopened this Jan 17, 2024
@AlekSi AlekSi mentioned this issue Jan 17, 2024
Merged
9 tasks
@AlekSi AlekSi reopened this Jan 17, 2024
@AlekSi AlekSi mentioned this issue Jan 18, 2024
Merged
9 tasks
AlekSi referenced this issue in FerretDB/FerretDB Jan 19, 2024
@AlekSi
Improve bson2 fuzzing (#3988)
2b45f90 
Closes #3759.
@AlekSi AlekSi reopened this Jan 19, 2024
@AlekSi AlekSi mentioned this issue Jan 22, 2024
Merged
9 tasks
@AlekSi AlekSi reopened this Jan 24, 2024
@AlekSi AlekSi mentioned this issue Mar 7, 2024
Merged
9 tasks
@AlekSi AlekSi reopened this Mar 12, 2024
@AlekSi AlekSi mentioned this issue Mar 12, 2024
Merged
9 tasks
@AlekSi AlekSi reopened this Mar 12, 2024
@AlekSi AlekSi transferred this issue from FerretDB/FerretDB Aug 15, 2024
@AlekSi AlekSi removed code/chore Code maintenance improvements not ready Issues that are not ready to be worked on; PRs that should skip CI labels Aug 15, 2024
@AlekSi AlekSi removed their assignment Aug 15, 2024
@AlekSi AlekSi changed the title Support lazy BSON decoding Encode methods should accept []byte Aug 15, 2024
@noisersup noisersup linked a pull request Sep 4, 2024 that will close this issue
Draft
@AlekSi AlekSi added the code/perf Performance improvements label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noisersup noisersup

Labels
code/perf Performance improvements
Projects
Current Engineering
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Encode methods accept []byte noisersup/wire
3 participants
@AlekSi @noisersup @ferretdb-bot