WIP: Traits for ScalarValues / VectorValues
#404
Conversation
There was a problem hiding this comment.
I think it looks good, and can be merged...
But we can use the traits in the reinit! methods aswell now:
Ferrite.jl/src/FEValues/cell_values.jl
Line 147 in 6684cb6
|
Just a general question... why not use VectorValues as supertype instead of Face/CellValues. What dictates what trait/property should be used as supertype, and what should be implemented as traits? |
|
The reason here was to literally replace the old scalar/vector value unions. Sure could be the other way around, but that would be a larger redesign. Would you argue that it really should be the other way around? |
|
Not worth redesigning I think, I was just wondering if it would be better and if there is some helpful rule to decide what should be used as traits/supertypes |
* traits for ScalarValues & VectorValues * remove outdated / wrong comments * rename to ScalarValue/VectorValued * replace isa(VectorValues) * change version to 0.3.2
A suggestion on using traits instead of Unions for defining
ScalarValuesandVectorValues.I want to use it for subtyping
Valueswithout copying a bunch of code from Ferrite. Could also be useful for custom definition of (less common?) problems like the one mentioned in #398.I'm happy to hear some feedback,
if this is appreciated I'll add some docs as well.