Fixes the discontinuous lagrange reference coords dispatch #559
Conversation
…order 0 RefTetrahedron dispatch
| function reference_coordinates(ip::DiscontinuousLagrange{2,RefTetrahedron,0}) | ||
| return [Vec{2,Float64}((1/3,1/3))] | ||
| end | ||
|
|
||
| function reference_coordinates(ip::DiscontinuousLagrange{3,RefTetrahedron,0}) | ||
| return [Vec{3,Float64}((1/4,1/4,1/4))] | ||
| end |
There was a problem hiding this comment.
We had a general solution via ntuple, right?
There was a problem hiding this comment.
no :D that's 1:1 the piece of code of the other branch
Codecov ReportBase: 92.93% // Head: 92.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
==========================================
- Coverage 92.93% 92.91% -0.02%
==========================================
Files 24 24
Lines 3978 3982 +4
==========================================
+ Hits 3697 3700 +3
- Misses 281 282 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Add a test? :) |
|
I already tried a bit of stuff to test interpolations, but I cannot find a good angle. Do you have something in mind how we can improve interpolation testing @fredrikekre ? |
|
Even some silly test like is useful to catch regressions IMO. |
No description provided.