Make showgrid work for all cells #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
reviewed
Feb 10, 2023
| @@ -708,25 +711,11 @@ end | |||
|
|
|||
| function Base.show(io::IO, ::MIME"text/plain", grid::Grid) | |||
| print(io, "$(typeof(grid)) with $(getncells(grid)) ") | |||
| typestrs = sort!(collect(Set(celltypes[typeof(x)] for x in grid.cells))) | |||
| str = join(io, typestrs, '/') | |||
| typestrs = sort!(collect(Set(repr(typeof(x)) for x in grid.cells))) | |||
There was a problem hiding this comment.
This seems to be really slow, try showing something like generate_grid(Triangle, (1000, 1000)) in the REPL.
There was a problem hiding this comment.
Sorry, missed that performance regression. Fixed in #559.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #420
Hit this problem again, would be nice to resolve this if possible!
Making new PR from a new branch as history got messed up when merging with master...
Side note: Came up when checking the discussion of how to parameterize the cell type, as the standard quadratic quad from Abaqus is not supported as this has
Serendipity-type interpolation (8 nodes)...